[Lldb-commits] [PATCH] D92820: [lldb] Deal gracefully with concurrency in the API instrumentation.

Frederic Riss via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Dec 10 08:42:33 PST 2020


friss accepted this revision.
friss added a comment.
This revision is now accepted and ready to land.

This LGTM.
There is one thing that you might want to address, but I'll leave it up to you (and even if you do it can be a different commit): with the introduction of `idx` variables, it becomes easy to get confused between `id` and `idx`(Or `CheckID` and `CheckIndex`) in the codebase. Not sure how to disambiguate, or if it's really worth it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92820/new/

https://reviews.llvm.org/D92820



More information about the lldb-commits mailing list