[Lldb-commits] [PATCH] D92643: [lldb] Lookup static const members in FindGlobalVariables

[Andy Yankovsky via Phabricator via lldb-commits]

werat added a comment.

Thanks for your review! If there are no objections to this patch, can you accept and land it for me? :)

In D92643#2445146 <https://reviews.llvm.org/D92643#2445146>, @labath wrote:

> On a higher level, I am also worried about what this (the fact that we have to do this kind of a search) says about the quality/usefulness of the debug_names index.

FWIW we're considering disabling `debug_names` completely for now, as it degrades performance significantly with no extra benefit. We can discuss that in more details if you're interested.

In D92643#2445146 <https://reviews.llvm.org/D92643#2445146>, @labath wrote:

> I think it would be useful to discuss this with the people responsible for the generation of the index in clang and the wider dwarf community. (Unfortunately, I don't have the bandwidth to drive that dicussion :( ).

Can't say I have a lot of expertise in DWARF, but I will try to research this more and reach out to clang/dwarf people.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92643/new/

https://reviews.llvm.org/D92643