[Lldb-commits] [PATCH] D82857: [LLDB] Add per-thread register infos shared pointer in gdb-remote

[Pavel Labath via Phabricator via lldb-commits]

labath added inline comments.


================
Comment at: lldb/source/Plugins/Process/gdb-remote/ThreadGDBRemote.cpp:47-48
+  // run-time update to register sizes and offsets..
+  ProcessSP process_sp(GetProcess());
+  if (process_sp) {
+    ProcessGDBRemote *gdb_process =
----------------
Can't you just use the `process` constructor argument here? (That's what makes this code simpler vs the separate function approach)


================
Comment at: lldb/source/Plugins/Process/gdb-remote/ThreadGDBRemote.cpp:52
+
+    if (!m_reg_info_sp) {
+      if (!gdb_process->m_register_info_sp->IsReconfigurable())
----------------
Is this ever false?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82857/new/

https://reviews.llvm.org/D82857