[Lldb-commits] [PATCH] D92712: [debugserver] Honor the cpu sub type if specified

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Dec 4 18:44:45 PST 2020


JDevlieghere created this revision.
JDevlieghere added a reviewer: jasonmolenda.
Herald added a subscriber: pengfei.
JDevlieghere requested review of this revision.

Use the newly added spawnattr API, `posix_spawnattr_setarchpref_np`, to select a slice preferences per cpu and subcpu types, instead of just cpu with `posix_spawnattr_setarchpref_np`. In the patch it only does this for `x86_64` and `x86_64h`, but I would like to extend the parsing to more subtypes.

Tested by compiling a fat binary with different print statements depending on the architecture. I considered adding a test for it, but it doesn't seem worth the hassle to figure out the host architecture and the availability.


https://reviews.llvm.org/D92712

Files:
  lldb/tools/debugserver/source/DNB.cpp
  lldb/tools/debugserver/source/DNBArch.cpp
  lldb/tools/debugserver/source/DNBArch.h
  lldb/tools/debugserver/source/MacOSX/MachProcess.h
  lldb/tools/debugserver/source/MacOSX/MachProcess.mm

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D92712.309708.patch
Type: text/x-patch
Size: 7755 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20201205/abcd224e/attachment.bin>


More information about the lldb-commits mailing list