[Lldb-commits] [PATCH] D82857: [LLDB] Add per-thread register infos shared pointer in gdb-remote

Diana Picus via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Dec 4 03:56:53 PST 2020


rovka added a comment.

Sorry, I had one more comment :) I think that should be all from my side.



================
Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:403
+  m_register_info_sp = std::make_shared<GDBRemoteDynamicRegisterInfo>();
+  m_register_info_sp->Clear();
 
----------------
Is it still necessary to call Clear? I think the default constructor should give us a "cleared" object.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82857/new/

https://reviews.llvm.org/D82857



More information about the lldb-commits mailing list