[Lldb-commits] [PATCH] D91734: [FastISel] Flush local value map on every instruction

[Paul Robinson via Phabricator via lldb-commits]

probinson added a comment.

The constant materialization (xorl) obviously does not belong in the prologue; I think the instruction ordering with the patch is preferable.
But, clearly we'd rather not have it attributed to line 0, but the line it actually belongs to.  I'll start looking into this.  Offhand the reduced example appears to be not unreasonably large :-)

We do have a gdb suite of some form running on our downstream compiler, but this patch series hasn't made it there yet. When I put a new patch up I'll tag you @dblaikie and you can try it out on your bot.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91734/new/

https://reviews.llvm.org/D91734