[Lldb-commits] [PATCH] D92425: [lldb] Don't reject empty or unnamed template parameter packs

Wed Dec 2 14:53:40 PST 2020

stella.stamenova added a comment.

In D92425#2428952 <https://reviews.llvm.org/D92425#2428952>, @teemperor wrote:

> In D92425#2428844 <https://reviews.llvm.org/D92425#2428844>, @stella.stamenova wrote:
>
>> This caused failures on the Windows lldb buildbot:
>>
>> http://lab.llvm.org:8011/#/builders/83/builds/1294
>>
>> Tests have to have unique names, so the two new added tests that use TestCase as the class name are both trying to write to the same log file and failing to do so.
>
> Thanks, fixed.
>
> FWIW, this (frankly silly) requirement is actually supposed to be fixed by D83767 <https://reviews.llvm.org/D83767>.

It would be great to finally have it fixed so don't have random failures because of file names!

It looks like the two tests are still failing though (different reason):

http://lab.llvm.org:8011/#/builders/83/builds/1332/steps/7/logs/stdio

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92425/new/

https://reviews.llvm.org/D92425