[Lldb-commits] [PATCH] D92103: [ASTImporter] Import the default argument of TemplateTypeParmDecl

Wed Dec 2 02:53:59 PST 2020

martong added a subscriber: balazske.
martong added a comment.

Hey Raphael, thanks for looking into the CTU crash!

I also had a look and I could reproduce that on Linux Ubuntu 18.04 with GCC 7. I think the discrepancy stems from GCC's libstdc++ and MacOS's libc++ implementation differences of `basic_streambuf`. This is the CXXRecordDecl which does not need an injected class name type (so there is the assert). However, the situation is more complex because there is a 5 long redecl chain (streambuf is forward declared in many places).

Anyway, I don't think that this patch itself caused the crash, it just revealed some other issues that are related to the possibly flawed import logic of injected class (name) types. I am adding another college @balazske as a subscriber because he started to investigate the crash deeper.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92103/new/

https://reviews.llvm.org/D92103