[Lldb-commits] [PATCH] D92314: [lldb] [Process/FreeBSDRemote] Implement GetLoadedModuleFileSpec() and GetFileLoadAddress()

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Dec 1 05:21:57 PST 2020


labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

These are basically workarounds for dynamic linker bugs, when we're not able to get complete information via r_debug. If your dynamic linker (loader) behaves, then it's not surprising that they make no effect.

Implementing them is fine. It might be nice to also add some explicit tests for these functions (via lldb-server tests, perhaps). We should have done something like that when we were adding these in the first place, but we weren't so big on testing then...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92314/new/

https://reviews.llvm.org/D92314



More information about the lldb-commits mailing list