[Lldb-commits] [PATCH] D92223: [lldb] Add support for looking up static const members

Shafik Yaghmour via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Nov 30 14:04:02 PST 2020


shafik added inline comments.


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3181
 
+  if (tag == DW_TAG_member && !const_value_form.IsValid()) {
+    // Allows only members with DW_AT_const_value attribute, i.e. static const
----------------
This is a nitpick but if we move the comment above the `if` we can remove the braces.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92223/new/

https://reviews.llvm.org/D92223



More information about the lldb-commits mailing list