[Lldb-commits] [PATCH] D92249: [LLDB/Python] Fix segfault on Python scripted breakpoints

Pedro Tammela via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Nov 30 03:56:58 PST 2020


tammela added a comment.

In D92249#2422205 <https://reviews.llvm.org/D92249#2422205>, @labath wrote:

> In D92249#2421639 <https://reviews.llvm.org/D92249#2421639>, @JDevlieghere wrote:
>
>> It appears there are many similar calls in this file, can you update those as well?
>
> If there are many of these calls, adding a static helper function for this purpose might be a good idea as well...

Yes, it looks like the same 3-line routine is being replicated across multiple functions. I will clean it up.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92249/new/

https://reviews.llvm.org/D92249



More information about the lldb-commits mailing list