[Lldb-commits] [PATCH] D92223: [lldb] Add support for looking up static const members

[Raphael Isemann via Phabricator via lldb-commits]

teemperor added reviewers: labath, jankratochvil.
teemperor added a comment.

Not sure who's the right person to review the SymbolFileDWARF.cpp/ManualDWARFIndex.cpp, but Pavel/Jan touched that not too long ago.

(D81471 <https://reviews.llvm.org/D81471> might also be an interested patch for you. That one is just waiting on me to add some of the requested tests).



================
Comment at: lldb/test/API/python_api/target/globals/TestTargetGlobals.py:5
+
+from __future__ import print_function
+
----------------
Unused import


================
Comment at: lldb/test/API/python_api/target/globals/TestTargetGlobals.py:8
+import unittest2
+import os
+from lldbsuite.test.decorators import *
----------------
Also unused?


================
Comment at: lldb/test/API/python_api/target/globals/TestTargetGlobals.py:45
+            process, breakpoint)
+        self.assertTrue(thread, "Thread is valid")
+
----------------
The code between here and `self.build()` can be simplified to:

```
        self.build()
       target, _, _, _ lldbutil.run_to_source_breakpoint(self, "// Set a break at entry to main.", lldb.SBFileSpec("main.cpp"))
```
And then the `setUp` can also be removed.

FWIW, I believe we don't need to launch any process for this test, so this might be enough to test this (while being a much faster test):
```
self.build()
target = self.dbg.CreateTarget(self.getBuildArtifact("a.out"))
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92223/new/

https://reviews.llvm.org/D92223