[Lldb-commits] [PATCH] D92035: [lldb] Use llvm::Optional for port in LaunchGDBServer

Wed Nov 25 04:49:27 PST 2020

labath accepted this revision.
labath added inline comments.
This revision is now accepted and ready to land.

================
Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp:197
 #endif
-  uint16_t *port_ptr = &port;
+  uint16_t *port_ptr = port.getPointer();
   if (m_socket_protocol == Socket::ProtocolTcp) {
----------------
DavidSpickett wrote:
> I know this is a bit unorthodox but things got messy trying to pass an Optional into StartDebugServerProcess. So I figured it's better to keep StartDebugServerProcess the same for now and limit the scope of any mistakes. (the logic gets quite hard to follow)
I think that's fine.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92035/new/

https://reviews.llvm.org/D92035