[Lldb-commits] [PATCH] D92063: [LLDB] RegisterInfoPOSIX_arm64 remove unused bytes from g/G packet

[Muhammad Omair Javaid via Phabricator via lldb-commits]

omjavaid created this revision.
omjavaid added a reviewer: labath.
Herald added subscribers: kristof.beyls, emaste.
omjavaid requested review of this revision.

This came up while putting together our new strategy to create g/G packets where register offsets are calculated in increasing order of register numbers without any unused spacing. RegisterInfoPOSIX_arm64::GPR size was being calculated after alignment correction to 8 bytes which meant there 4 bytes unused space between last gpr (cpsr) and first vector register V. To remove any ambiguity I have placed a 4 byte pad at the end of RegisterInfoPOSIX_arm64::GPR and also subtracted the same from any offset calculation to avoid any unused fragment in g/G packet which will eventually break our offset calculation algorithm.


https://reviews.llvm.org/D92063

Files:
  lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_arm64.cpp
  lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp
  lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.h
  lldb/source/Plugins/Process/Utility/RegisterInfoPOSIX_arm64.cpp
  lldb/source/Plugins/Process/Utility/RegisterInfoPOSIX_arm64.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D92063.307475.patch
Type: text/x-patch
Size: 6620 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20201125/d14ff64f/attachment-0001.bin>