[Lldb-commits] [PATCH] D87442: [lldb][AArch64/Linux] Show memory tagged memory regions

[Pavel Labath via Phabricator via lldb-commits]

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

In D87442#2405681 <https://reviews.llvm.org/D87442#2405681>, @DavidSpickett wrote:

> - Use assertIn
> - Cleanup Status/Error handling
> - Refactor test so it runs once and we skip based on whether it returns a value or hits a breakpoint.
> - Seperated exit codes for non MTE toolchain and non MTE target, for more specific skip reasons.
>
> On the test, hopefully the comment in main.c
> makes sense. Here's a cut down demo of what I'm
> explaining:
> https://godbolt.org/z/rex96b
>
> This means we can always set an exact breakpoint,
> we just won't hit it unless you have MTE. Which is
> what we want.

I see.

Maybe a less convoluted pattern would be

  void test_mte(void *page) {}
  
  int main() {
  #ifdef MTE
    ...
    test_mte(mmap(...));
    return 0;
  #else
    return 47;
  #endif
  }

and setting a breakpoint on `test_mte`. But this is fine too....


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87442/new/

https://reviews.llvm.org/D87442