[Lldb-commits] [PATCH] D91810: [lldb] [Process/FreeBSD] Fix 'process connect' plugin choice

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

In D91810#2407483 <https://reviews.llvm.org/D91810#2407483>, @mgorny wrote:

> In D91810#2407461 <https://reviews.llvm.org/D91810#2407461>, @labath wrote:
>
>> I think that the real fix here would be to change the plugin selection logic (Target::CreateProcess) to convey the fact that we're looking for a connectable plugin. The method already contains a `FileSpec *core_file` argument, which I guess is needed to select the proper core file subclass, so adding a can_connect argument would not be unreasonable (though not exactly pretty either).
>
> Would maybe a static class variable ('property'?) be cleaner?

It might, though I am not sure how would you make that interact with the current selection logic. And I think you'll still need to pass a flag all the way to Process::FindPlugin, as that's the thing which iterates over registered classes.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91810/new/

https://reviews.llvm.org/D91810