[Lldb-commits] [PATCH] D90857: [lldb] add a missing dependency on intrinsics_gen

[Richard Howell via Phabricator via lldb-commits]

rmaz added a comment.

> I'd still like to hear an explanation on how is this patch relevant (in this repository).

Apologies, missed the last notification.

> Judging by the error message, this dependency is not correct even in the swift fork. lldbSymbol does not have a direct dependency on llvmIR. It has a dependency on swift (through SwiftASTContext), and swift (through AST/Builtins.h) has a dependency on the generated headers.

Correct.

> So, the right fix should be to add a lldbSymbol->Swift dependency (if one isn't there already), and then a swift->LLVMIR dep.

This sounds reasonable, the Swift build script seems to enforce a similar compilation order of:

1. LLVM & Clang
2. Swift
3. LLDB

There are some existing dependencies on Swift libs in standalone mode, let me take a look at this approach instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90857/new/

https://reviews.llvm.org/D90857