[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values

[Michał Górny via Phabricator via lldb-commits]

mgorny marked 4 inline comments as done.
mgorny added inline comments.


================
Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp:537
+    uint16_t sw = m_xstate->fxsave.fstat;
+    llvm::ArrayRef<MMSReg> st_regs{m_xstate->fxsave.stmm, 8};
+    reg_value.SetUInt16(AbridgedToFullTagWord(abridged_tw, sw, st_regs));
----------------
labath wrote:
> Is this really needed? I would have hoped that just passing `m_xstate->fxsave.stmm` would be enough and that the c array constructor of ArrayRef would do the right thing...
Indeed. I have missed that `ArrayRef` can figure the size of a C-style array out.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91504/new/

https://reviews.llvm.org/D91504