[Lldb-commits] [PATCH] D91645: [lldb] [test] Un-XFAIL tests on freebsd/i386

Wed Nov 18 07:56:45 PST 2020

emaste added inline comments.

================
Comment at: lldb/test/API/functionalities/exec/TestExec.py:19

-    @expectedFailureAll(archs=['i386'], bugnumber="rdar://28656532")
+    @expectedFailureAll(archs=['i386'],
+                        oslist=no_match(["freebsd"]),
----------------
labath wrote:
> labath wrote:
> > mgorny wrote:
> > > emaste wrote:
> > > > Interesting, so FreeBSD is now the only OS where this test passes on i386?
> > > > 
> > > > Of course rdar://28656532 is opaque, would be nice if Apple folks can provide some insight on this.
> > > I suspect others might pass too and this is a Darwin-specific issue but I don't have 32-bit NetBSD install handy at the moment, and LLDB doesn't seem to work at all on Arch Linux 32 for some obscure reason.
> > I was actually running the test on a 64-bit multilib system. It's possible that a pure 32-bit system behaves differently.
> (or just a 32-bit build of lldb)
Ah, fair point. I'm not all that interested in FreeBSD/i386 tbh, it just seemed surprising.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91645/new/

https://reviews.llvm.org/D91645