[Lldb-commits] [lldb] 50f12ad - [lldb] Fix a couple of remote llgs tests

David Spickett via lldb-commits lldb-commits at lists.llvm.org
Wed Nov 18 03:36:53 PST 2020


Author: David Spickett
Date: 2020-11-18T11:36:45Z
New Revision: 50f12ade2de1b30e989c13f410461cb27c126f13

URL: https://github.com/llvm/llvm-project/commit/50f12ade2de1b30e989c13f410461cb27c126f13
DIFF: https://github.com/llvm/llvm-project/commit/50f12ade2de1b30e989c13f410461cb27c126f13.diff

LOG: [lldb] Fix a couple of remote llgs tests

init_llgs_test no longer takes an argument
but these two were not updated.

Also fix some mistakes in TestAutoInstallMainExecutable
to get it passing again.

Reviewed By: JDevlieghere, labath

Differential Revision: https://reviews.llvm.org/D91612

Added: 
    

Modified: 
    lldb/test/API/commands/target/auto-install-main-executable/TestAutoInstallMainExecutable.py
    lldb/test/API/tools/lldb-server/platform-process-connect/TestPlatformProcessConnect.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/commands/target/auto-install-main-executable/TestAutoInstallMainExecutable.py b/lldb/test/API/commands/target/auto-install-main-executable/TestAutoInstallMainExecutable.py
index 47c016e14c2d..fe4e124cd605 100644
--- a/lldb/test/API/commands/target/auto-install-main-executable/TestAutoInstallMainExecutable.py
+++ b/lldb/test/API/commands/target/auto-install-main-executable/TestAutoInstallMainExecutable.py
@@ -19,7 +19,7 @@ class TestAutoInstallMainExecutable(gdbremote_testcase.GdbRemoteTestCaseBase):
     @expectedFailureAll(hostoslist=["windows"], triple='.*-android')
     def test_target_auto_install_main_executable(self):
         self.build()
-        self.init_llgs_test(False)
+        self.init_llgs_test()
 
         # Manually install the modified binary.
         working_dir = lldb.remote_platform.GetWorkingDirectory()
@@ -77,10 +77,10 @@ def test_target_auto_install_main_executable(self):
                                         (os.path.join(working_dir,dest.GetFilename()),
                                             self.getBuildArtifact("a.out")))
 
-        target = new_debugger.GetSelectedTarget()
+        target = self.dbg.GetSelectedTarget()
         breakpoint = target.BreakpointCreateByName("main")
 
-        launch_info = taget.GetLaunchInfo()
+        launch_info = target.GetLaunchInfo()
         error = lldb.SBError()
         process = target.Launch(launch_info, error)
         self.assertTrue(process, PROCESS_IS_VALID)

diff  --git a/lldb/test/API/tools/lldb-server/platform-process-connect/TestPlatformProcessConnect.py b/lldb/test/API/tools/lldb-server/platform-process-connect/TestPlatformProcessConnect.py
index c9331e7d09a5..fcfb0a829e03 100644
--- a/lldb/test/API/tools/lldb-server/platform-process-connect/TestPlatformProcessConnect.py
+++ b/lldb/test/API/tools/lldb-server/platform-process-connect/TestPlatformProcessConnect.py
@@ -16,7 +16,7 @@ class TestPlatformProcessConnect(gdbremote_testcase.GdbRemoteTestCaseBase):
     @expectedFailureAll(hostoslist=["windows"], triple='.*-android')
     def test_platform_process_connect(self):
         self.build()
-        self.init_llgs_test(False)
+        self.init_llgs_test()
 
         working_dir = lldb.remote_platform.GetWorkingDirectory()
         src = lldb.SBFileSpec(self.getBuildArtifact("a.out"))


        


More information about the lldb-commits mailing list