[Lldb-commits] [PATCH] D91497: [lldb] Add explicit 64-bit fip/fdp registers on x86_64

Wed Nov 18 03:05:31 PST 2020

mgorny marked an inline comment as done.
mgorny added inline comments.

================
Comment at: lldb/unittests/Process/Utility/RegisterContextFreeBSDTest.cpp:82-83
   EXPECT_OFF(fop_x86_64, 0x06, 2);
   // NB: Technically fiseg/foseg are 16-bit long and the higher 16 bits
   // are reserved.  However, we use them to access/recombine 64-bit FIP/FDP.
   EXPECT_OFF(fioff_x86_64, 0x08, 4);
----------------
labath wrote:
> I guess this isn't really true anymore?
I'll update the comment to make it clear it's backwards compat thing.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91497/new/

https://reviews.llvm.org/D91497