[Lldb-commits] [PATCH] D91508: [LLDB/Lua] add support for one-liner breakpoint callback
Pedro Tammela via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Nov 17 12:15:47 PST 2020
tammela added inline comments.
================
Comment at: lldb/source/Plugins/ScriptInterpreter/Lua/ScriptInterpreterLua.cpp:200
+ Debugger &debugger = target->GetDebugger();
+ ScriptInterpreterLua *lua_interpreter =
+ static_cast<ScriptInterpreterLua *>(debugger.GetScriptInterpreter());
----------------
labath wrote:
> How is `lua_interpreter` different from `this`?
Are you asking why I didn't go for `m_script_interpreter`?
This function is static (on the class declaration), perhaps it's clearer a `static` keyword here as well?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91508/new/
https://reviews.llvm.org/D91508
More information about the lldb-commits
mailing list