[Lldb-commits] [PATCH] D91612: [lldb] Fix a couple of remote llgs tests

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Nov 17 09:32:43 PST 2020


labath accepted this revision.
labath added a comment.

In D91612#2399408 <https://reviews.llvm.org/D91612#2399408>, @DavidSpickett wrote:

> I presume these tests aren't commonly run or have been masked by the expected failures.

Yes, that seems to be the case, though I don't actually see a reason for that.

This is definitely the right fix, though it seems that we have a bigger problem in that one of the decorators is misbehaving and causing the tests not to run.

My money is on `@skipIf(remote=False)`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91612/new/

https://reviews.llvm.org/D91612



More information about the lldb-commits mailing list