[Lldb-commits] [PATCH] D87637: [lldb/test] Enable faulthandler in dotest

Mon Nov 16 10:44:03 PST 2020

rupprecht added a comment.

In D87637#2395603 <https://reviews.llvm.org/D87637#2395603>, @teemperor wrote:

> Yeah I don't think this revision is to blame as just disabling the code here doesn't bring back the backtraces. Doesn't explain what happened to them, but that's probably on me to figure out. Really sorry for the noise, closing this again.

No worries, this is an entirely reasonable change to suspect.

Not sure if you saw, but further on down there is also:

  # Install the control-c handler.
  unittest2.signals.installHandler()

However, removing that in addition to this still does not seem to get the C++ backtraces working. I'm guessing there's a call to `EnablePrettyStackTrace` that used to be happening and was accidentally removed.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87637/new/

https://reviews.llvm.org/D87637