[Lldb-commits] [PATCH] D91497: [lldb] Add explicit 64-bit fip/fdp registers on x86_64

[Michał Górny via Phabricator via lldb-commits]

mgorny added a comment.

Tested on Linux, FreeBSD and NetBSD. I've presumed we want fip/fdp only on amd64.



================
Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_64.cpp:84
     lldb_fctrl_x86_64,     lldb_fstat_x86_64, lldb_ftag_x86_64,
-    lldb_fop_x86_64,       lldb_fiseg_x86_64, lldb_fioff_x86_64,
-    lldb_foseg_x86_64,     lldb_fooff_x86_64, lldb_mxcsr_x86_64,
+    lldb_fop_x86_64,       lldb_fiseg_x86_64, lldb_fioff_x86_64, lldb_fip_x86_64,
+    lldb_foseg_x86_64,     lldb_fooff_x86_64, lldb_fdp_x86_64, lldb_mxcsr_x86_64,
----------------
Note to self: remember to `clang-format` before committing.


================
Comment at: lldb/source/Plugins/Process/Utility/RegisterInfos_x86_64.h:99
                                lldb_mm##i##_x86_64 },                          \
                                nullptr, nullptr, nullptr, 0                    \
   }
----------------
@labath, also, shouldn't we have overlaps set between ST and MM registers?


================
Comment at: lldb/source/Plugins/Process/Utility/RegisterInfos_x86_64.h:262
     DEFINE_FPR(fioff,     ptr.i386_.fioff, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM),
+    DEFINE_FPR(fip,       ptr.x86_64.fip,  LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM),
     DEFINE_FPR(foseg,     ptr.i386_.foseg, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM),
----------------
@labath, do you want me to set overlaps here like rax/eax... does? If yes, any suggestion on the style?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91497/new/

https://reviews.llvm.org/D91497