[Lldb-commits] [PATCH] D91216: [lldb] [Process/FreeBSDRemote] Access GPR via reginfo offsets

Fri Nov 13 02:02:11 PST 2020

labath added inline comments.

================
Comment at: lldb/unittests/Process/Utility/RegisterContextFreeBSDTests.cpp:32
+
+#define ASSERT_GPR_X86_64(regname)                                             \
+  EXPECT_THAT(                                                                 \
----------------
Also, please rename this to `EXPECT_GRP_X86_64`. `ASSERT_` is for macros that terminate test when they fail.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91216/new/

https://reviews.llvm.org/D91216