[Lldb-commits] [PATCH] D91241: [LLDB] Make offset field optional in RegisterInfo packet for Arm64

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Nov 12 05:47:39 PST 2020

labath added a comment.

That's a good point. Maybe this does need to be a two-pass algorithm (first compute the offsets of primary registers, then fill out subregs). But that doesn't mean the two passes should be in two completely separate files. It would still be better if that was done in a single place. Maybe we can move all the offset computation out of the parsing loop and into a separate helper function. Doing the computation inside the loop is not really correct anyway, as the registers in the target.xml don't have to come in ascending regnum order (all stubs probably send them that way, but I don't think they _have_ to do that).



More information about the lldb-commits mailing list