[Lldb-commits] [PATCH] D91293: [lldb] [Process/FreeBSDRemote] Modernize and simplify YMM logic
Michał Górny via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu Nov 12 01:41:51 PST 2020
mgorny added inline comments.
Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_64.cpp:615
+ if (offset == LLDB_INVALID_XSAVE_OFFSET)
+ return false;
> When does this return false? When the ymm regs are not available?
Yes. Note that this change brings us closer to being able to disable whole regsets — I just need to figure out how to do it ;-).
Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_64.h:83
size_t GetDBROffset() const;
+ bool GetYMMSplitReg(uint32_t reg, void **xmm, void **ymm_hi);
> `void *&`
Are you sure about this? I feel like the whole `&` deal is quite confusing (read: shouldn't have happened). You don't know whether the method modifies the variables passed to it unless you look at the method prototype.
CHANGES SINCE LAST ACTION
More information about the lldb-commits