[Lldb-commits] [PATCH] D90729: [trace][intel-pt] Scaffold the 'thread trace start | stop' commands

[walter erquinigo via Phabricator via lldb-commits]

wallace marked 10 inline comments as done.
wallace added inline comments.


================
Comment at: lldb/include/lldb/Target/ProcessTrace.h:1
 //===-- ProcessTrace.h ------------------------------------------*- C++ -*-===//
 //
----------------
clayborg wrote:
> Should ProcessTrace and ThreadTrace be moved to the Process plug-in directory?
can't do that. I think Pavel and other guys warned me of cross-referencing between plugin-folders. It is safer this way, as they are base classes for trace plug-ins.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90729/new/

https://reviews.llvm.org/D90729