[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Nov 11 12:36:50 PST 2020

JDevlieghere added a subscriber: sgraenitz.
JDevlieghere added a comment.

In D69589#1769663 <https://reviews.llvm.org/D69589#1769663>, @sgraenitz wrote:

> I'd recommend to be careful when making a change of this size. There are a lot of possible configurations.
> If you split it up into a few smaller and more dedicated commits, you will make your life easier. Otherwise someone might just revert everything if this happens to break a bot.


Please include me as a reviewer when making changes like this to the build system, especially if it affects the framework build. It's only sparsely tested upstream (in part because we have a bunch of downstream changes) but it is the way we ship LLDB to our customers so it is really import to us. If I happen to miss the review I likely won't discover issues until the next time we rebranch at which point it might be a lot harder to figure them out.

  rG LLVM Github Monorepo



More information about the lldb-commits mailing list