[Lldb-commits] [lldb] b7c06dc - [ThreadPlan] Add a test for `thread step-in -r`, NFC (reapply)

Vedant Kumar via lldb-commits lldb-commits at lists.llvm.org
Wed Nov 11 10:44:08 PST 2020


Author: Vedant Kumar
Date: 2020-11-11T10:43:38-08:00
New Revision: b7c06dcb739f8a30c8dc9d4cc8832a9c939a1c49

URL: https://github.com/llvm/llvm-project/commit/b7c06dcb739f8a30c8dc9d4cc8832a9c939a1c49
DIFF: https://github.com/llvm/llvm-project/commit/b7c06dcb739f8a30c8dc9d4cc8832a9c939a1c49.diff

LOG: [ThreadPlan] Add a test for `thread step-in -r`, NFC (reapply)

Adds test coverage for ThreadPlanStepInRange::SetAvoidRegexp, but
disables the test on Windows.

See:
http://lab.llvm.org:8080/coverage/coverage-reports/coverage/Users/buildslave/jenkins/workspace/coverage/llvm-project/lldb/source/Target/ThreadPlanStepInRange.cpp.html#L309

Differential Revision: https://reviews.llvm.org/D91220

Added: 
    lldb/test/API/lang/c/stepping/TestThreadStepInAvoidRegexp.py

Modified: 
    lldb/packages/Python/lldbsuite/test/lldbtest.py
    lldb/test/API/lang/c/stepping/main.c

Removed: 
    


################################################################################
diff  --git a/lldb/packages/Python/lldbsuite/test/lldbtest.py b/lldb/packages/Python/lldbsuite/test/lldbtest.py
index f7d59a8a065c..89c25eb55516 100644
--- a/lldb/packages/Python/lldbsuite/test/lldbtest.py
+++ b/lldb/packages/Python/lldbsuite/test/lldbtest.py
@@ -126,6 +126,8 @@
 
 SOURCE_DISPLAYED_CORRECTLY = "Source code displayed correctly"
 
+STEP_IN_SUCCEEDED = "Thread step-in succeeded"
+
 STEP_OUT_SUCCEEDED = "Thread step-out succeeded"
 
 STOPPED_DUE_TO_EXC_BAD_ACCESS = "Process should be stopped due to bad access exception"

diff  --git a/lldb/test/API/lang/c/stepping/TestThreadStepInAvoidRegexp.py b/lldb/test/API/lang/c/stepping/TestThreadStepInAvoidRegexp.py
new file mode 100644
index 000000000000..ca58b4afcb57
--- /dev/null
+++ b/lldb/test/API/lang/c/stepping/TestThreadStepInAvoidRegexp.py
@@ -0,0 +1,34 @@
+"""
+Test thread step-in [ -r | --step-over-regexp ].
+"""
+
+
+
+import lldb
+from lldbsuite.test.lldbtest import *
+import lldbsuite.test.lldbutil as lldbutil
+
+
+class ThreadStepInAvoidRegexTestCase(TestBase):
+
+    mydir = TestBase.compute_mydir(__file__)
+
+    def setUp(self):
+        TestBase.setUp(self)
+        self.line2 = line_number('main.c', '// assignment to B2')
+
+    @skipIfWindows
+    def test_step_out_avoid_regexp(self):
+        """Exercise thread step-in -r"""
+        self.build()
+        lldbutil.run_to_source_breakpoint(self,
+                'frame select 2, thread step-out while stopped',
+                lldb.SBFileSpec('main.c'))
+
+        # Now step in, skipping the frames for 'b' and 'a'.
+        self.runCmd("thread step-in -r 'a'")
+
+        # We should be at the assignment to B2.
+        self.expect("thread backtrace", STEP_IN_SUCCEEDED,
+                    substrs=["stop reason = step in"],
+                    patterns=["frame #0.*main.c:%d" % self.line2])

diff  --git a/lldb/test/API/lang/c/stepping/main.c b/lldb/test/API/lang/c/stepping/main.c
index 43b5cfab183a..8237ebf984c9 100644
--- a/lldb/test/API/lang/c/stepping/main.c
+++ b/lldb/test/API/lang/c/stepping/main.c
@@ -39,7 +39,7 @@ int main (int argc, char const *argv[])
 {
     int A1 = a(1); // frame select 2, thread step-out while stopped at "c(1)"
 
-    int B2 = b(2);
+    int B2 = b(2); // assignment to B2
 
     int A3 = a(3); // frame select 1, thread step-out while stopped at "c(3)"
 


        


More information about the lldb-commits mailing list