[Lldb-commits] [PATCH] D87442: [lldb] Show flags for memory regions

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

I think this looks pretty good now. Some questions inline...



================
Comment at: lldb/source/Target/MemoryRegionInfo.cpp:10
 #include "lldb/Target/MemoryRegionInfo.h"
+#include "lldb/Utility/LLDBAssert.h"
 
----------------
unused?


================
Comment at: lldb/test/API/linux/aarch64/mte_memory_region/main.c:9-14
+  if (!(getauxval(AT_HWCAP2) & HWCAP2_MTE))
+    return 1;
+
+  int got = prctl(PR_SET_TAGGED_ADDR_CTRL, PR_TAGGED_ADDR_ENABLE, 0, 0, 0);
+  if (got)
+    return 1;
----------------
Instead of duplicating these checks in dotest, maybe we could use the result of the inferior as a indication to skip the test. Like, if, instead of hitting the breakpoint, the inferior exits with code 47, we know that the required cpu feature is not supported?


================
Comment at: lldb/unittests/Process/Utility/LinuxProcMapsTest.cpp:46-48
+      llvm::handleAllErrors(
+          Info.takeError(),
+          [this](const llvm::StringError &e) { err_str = e.getMessage(); });
----------------
err_str = toString(Info.takeError());


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87442/new/

https://reviews.llvm.org/D87442