[Lldb-commits] [PATCH] D91220: [ThreadPlan] Add a test for `thread step-in -r`, NFC

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

It's easier to read these tests if you use "lldbutil.run_to_source_breakpoint" to remove all that boilerplate.

Other than that LGTM.  Thanks for adding the test!



================
Comment at: lldb/test/API/lang/c/stepping/TestThreadStepInAvoidRegexp.py:27-45
+        exe = self.getBuildArtifact("a.out")
+        self.runCmd("file " + exe, CURRENT_EXECUTABLE_SET)
+
+        # Create a breakpoint inside function 'c'.
+        lldbutil.run_break_set_by_file_and_line(
+            self, "main.c", self.line1, num_expected_locations=1)
+
----------------
All this can be collapsed into

lldbutil.run_to_source_breakpoint("// frame select 2, thread step-out...", lldb.SBFileSpec("main.c"))

and it will do all the right checks for you.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91220/new/

https://reviews.llvm.org/D91220