[Lldb-commits] [PATCH] D91193: [lldb] Fine tune expect() validation
Raphael Isemann via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Nov 10 12:38:51 PST 2020
teemperor added a comment.
In D91193#2386832 <https://reviews.llvm.org/D91193#2386832>, @kastiglione wrote:
> @teemperor maybe? Do you mean validation should go in `runCmd`? Or do you mean something else?
I meant that to my knowledge command execution where the only expectation is that they succeed (so, no output checking) are supposed to be done via `runCmd`. `expect` is also documented as `Similar to runCmd; with additional expect style output matching ability.`, so if we allow calling `expect` without the additional `expect style matching ability`, then we might as well remove `runCmd`. So IMHO the current implementation of expect is just fine.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits