[Lldb-commits] [PATCH] D91167: [lldb] [Process/NetBSD] Copy the recent improvements from FreeBSD

[Michał Górny via Phabricator via lldb-commits]

mgorny created this revision.
mgorny added reviewers: krytarowski, labath.
Herald added subscribers: arichardson, emaste.
mgorny requested review of this revision.

Copy the recent improvements from the FreeBSDRemote plugin, notably:

- moving event reporting setup into SetupTrace() helper

- adding more debug info into SIGTRAP handling

- handling user-generated (and unknown) SIGTRAP events

- adding missing error handling to the generic signal handler

- fixing attaching to processes

- switching watchpoint helpers to use llvm::Error

- minor style and formatting changes

This fixes a number of tests, mostly related to fixed attaching.


https://reviews.llvm.org/D91167

Files:
  lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp
  lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.h
  lldb/source/Plugins/Process/NetBSD/NativeRegisterContextNetBSD.h
  lldb/source/Plugins/Process/NetBSD/NativeRegisterContextNetBSD_x86_64.cpp
  lldb/source/Plugins/Process/NetBSD/NativeRegisterContextNetBSD_x86_64.h
  lldb/source/Plugins/Process/NetBSD/NativeThreadNetBSD.cpp
  lldb/source/Plugins/Process/NetBSD/NativeThreadNetBSD.h
  lldb/test/API/commands/process/attach/TestProcessAttach.py
  lldb/test/API/commands/register/register/register_command/TestRegisters.py
  lldb/test/API/functionalities/deleted-executable/TestDeletedExecutable.py
  lldb/test/API/functionalities/thread/num_threads/TestNumThreads.py
  lldb/test/API/python_api/hello_world/TestHelloWorld.py
  lldb/test/API/tools/lldb-server/TestGdbRemoteAttach.py
  lldb/test/API/tools/lldb-server/TestGdbRemoteKill.py
  lldb/test/API/tools/lldb-server/TestGdbRemoteProcessInfo.py
  lldb/test/API/tools/lldb-server/TestLldbGdbServer.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D91167.304199.patch
Type: text/x-patch
Size: 18443 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20201110/ec5cc2f9/attachment-0001.bin>