[Lldb-commits] [PATCH] D90987: [lldb] Avoid confusing crashes during reproducer replay when initialization failed

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added inline comments.


================
Comment at: lldb/source/API/SystemInitializerFull.cpp:46
+    if (repro::Reproducer::Instance().IsReplaying())
+      std::_Exit(EXIT_FAILURE);
+    return error;
----------------
labath wrote:
> labath wrote:
> > Print the error that has happened? maybe via `report_fatal_error` ?
> Btw, there's a new report_fatal_error overload taking an llvm::Error -- I meant to use that one :)
😍


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90987/new/

https://reviews.llvm.org/D90987