[Lldb-commits] [PATCH] D91032: [lldb] [Process/FreeBSDRemote] Explicitly copy dbregs to new threads

Michał Górny via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Nov 10 05:05:15 PST 2020


mgorny added inline comments.


================
Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeProcessFreeBSD.cpp:214
+      llvm::Error error = t.CopyWatchpointsFrom(
+          static_cast<NativeThreadFreeBSD &>(*GetCurrentThread()));
+      if (error) {
----------------
labath wrote:
> maybe this cast could be inside `GetCurrentThread`? Linux has it that way...
I suppose that makes sense. I'll try it in a followup commit.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91032/new/

https://reviews.llvm.org/D91032



More information about the lldb-commits mailing list