[Lldb-commits] [PATCH] D91056: [lldb] [test] Skip ObjC-based tests via 'objc' category
Raphael Isemann via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Nov 10 02:02:36 PST 2020
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks for cleaning this up, it's really appreciated!
Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:839
+ from . import lldbplatformutil
+ if not lldbplatformutil.platformIsDarwin():
nit: we do `from lldbsuite.test import lldbplatformutil` in the surrounding code, so that seems more consistent.
Comment at: lldb/test/API/functionalities/tsan/multiple/TestTsanMultiple.py:16
> This one's curious. I'm wondering why it's explicitly marked for all the platforms while it.s clearly a `.m` file ;-).
For the record: I think those XFails were just copied to all sanitizers tests that were failing on Linux (independently of whether the issue was lacking sanitizer support on Linux or as here Obj-C support missing).
CHANGES SINCE LAST ACTION
More information about the lldb-commits