[Lldb-commits] [PATCH] D91065: [lldb] [test] Rename '.categories' to 'categories'

[Michał Górny via Phabricator via lldb-commits]

mgorny created this revision.
mgorny added reviewers: labath, teemperor, krytarowski, emaste.
mgorny requested review of this revision.

Make category-specifying files visible.  There is really no good reason
to keep them hidden, and having them visible increases the chances
that someone will actually spot them.


https://reviews.llvm.org/D91065

Files:
  lldb/packages/Python/lldbsuite/test/test_result.py
  lldb/test/API/api/multiple-debuggers/.categories
  lldb/test/API/api/multiple-debuggers/categories
  lldb/test/API/commands/command/.categories
  lldb/test/API/commands/command/categories
  lldb/test/API/commands/expression/.categories
  lldb/test/API/commands/expression/categories
  lldb/test/API/commands/expression/completion/.categories
  lldb/test/API/commands/expression/completion/categories
  lldb/test/API/commands/expression/import-std-module/.categories
  lldb/test/API/commands/expression/import-std-module/categories
  lldb/test/API/commands/frame/recognizer/.categories
  lldb/test/API/commands/frame/recognizer/categories
  lldb/test/API/commands/watchpoints/.categories
  lldb/test/API/commands/watchpoints/categories
  lldb/test/API/functionalities/abbreviation/.categories
  lldb/test/API/functionalities/abbreviation/categories
  lldb/test/API/functionalities/alias/.categories
  lldb/test/API/functionalities/alias/categories
  lldb/test/API/functionalities/asan/.categories
  lldb/test/API/functionalities/asan/categories
  lldb/test/API/functionalities/backticks/.categories
  lldb/test/API/functionalities/backticks/categories
  lldb/test/API/functionalities/completion/.categories
  lldb/test/API/functionalities/completion/categories
  lldb/test/API/functionalities/darwin_log/.categories
  lldb/test/API/functionalities/darwin_log/categories
  lldb/test/API/functionalities/data-formatter/.categories
  lldb/test/API/functionalities/data-formatter/categories
  lldb/test/API/functionalities/data-formatter/data-formatter-objc/.categories
  lldb/test/API/functionalities/data-formatter/data-formatter-objc/categories
  lldb/test/API/functionalities/load_unload/.categories
  lldb/test/API/functionalities/load_unload/categories
  lldb/test/API/functionalities/load_using_paths/.categories
  lldb/test/API/functionalities/load_using_paths/categories
  lldb/test/API/functionalities/mtc/.categories
  lldb/test/API/functionalities/mtc/categories
  lldb/test/API/functionalities/thread/step_until/.categories
  lldb/test/API/functionalities/thread/step_until/categories
  lldb/test/API/functionalities/tsan/.categories
  lldb/test/API/functionalities/tsan/categories
  lldb/test/API/functionalities/ubsan/.categories
  lldb/test/API/functionalities/ubsan/categories
  lldb/test/API/functionalities/wrong_commands/.categories
  lldb/test/API/functionalities/wrong_commands/categories
  lldb/test/API/lang/c/step-target/.categories
  lldb/test/API/lang/c/step-target/categories
  lldb/test/API/lang/cpp/char1632_t/.categories
  lldb/test/API/lang/cpp/char1632_t/categories
  lldb/test/API/lang/cpp/wchar_t/.categories
  lldb/test/API/lang/cpp/wchar_t/categories
  lldb/test/API/lang/objc/.categories
  lldb/test/API/lang/objc/categories
  lldb/test/API/lang/objc/objc-dyn-sbtype/.categories
  lldb/test/API/lang/objc/objc-dyn-sbtype/categories
  lldb/test/API/lang/objcxx/.categories
  lldb/test/API/lang/objcxx/categories
  lldb/test/API/macosx/nslog/.categories
  lldb/test/API/macosx/nslog/categories
  lldb/test/API/python_api/.categories
  lldb/test/API/python_api/categories
  lldb/test/API/python_api/watchpoint/.categories
  lldb/test/API/python_api/watchpoint/categories
  lldb/test/API/tools/lldb-server/.categories
  lldb/test/API/tools/lldb-server/categories
  lldb/test/API/tools/lldb-vscode/.categories
  lldb/test/API/tools/lldb-vscode/categories


Index: lldb/packages/Python/lldbsuite/test/test_result.py
===================================================================
--- lldb/packages/Python/lldbsuite/test/test_result.py
+++ lldb/packages/Python/lldbsuite/test/test_result.py
@@ -112,7 +112,7 @@
     def _getFileBasedCategories(self, test):
         """
         Returns the list of categories to which this test case belongs by
-        collecting values of ".categories" files. We start at the folder the test is in
+        collecting values of "categories" files. We start at the folder the test is in
         and traverse the hierarchy upwards until the test-suite root directory.
         """
         start_path = self._getTestPath(test)
@@ -126,7 +126,7 @@
 
         categories = set()
         while not os.path.samefile(folder, test_root):
-            categories_file_name = os.path.join(folder, ".categories")
+            categories_file_name = os.path.join(folder, "categories")
             if os.path.exists(categories_file_name):
                 categories_file = open(categories_file_name, 'r')
                 categories_str = categories_file.readline().strip()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D91065.303807.patch
Type: text/x-patch
Size: 1146 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20201109/17abf699/attachment-0001.bin>