[Lldb-commits] [PATCH] D91007: [lldb] [Process/FreeBSDRemote] Fix handling user-generated SIGTRAP

Mon Nov 9 01:01:14 PST 2020

labath added inline comments.

================
Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeProcessFreeBSD.cpp:287
+    // probably a unknown event-generated SIGTRAP.
+    return;
   }
----------------
mgorny wrote:
> labath wrote:
> > What will happen in case this returns? Will the process auto-resume or just hang stopped? It sounds like it would still be useful to report this as "SIGTRAP" even if we are unable to give any details about it...
> Good catch. Should it be reported as an arbitrary SIGTRAP then or maybe as a trace trap?
I don't have a strong opinion there. I'd probably just go with a regular SIGTRAP.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91007/new/

https://reviews.llvm.org/D91007