[Lldb-commits] [PATCH] D91014: [lldb] Fix `DW_AT_decl_file` from `DW_AT_specification` from a different CU

Mon Nov 9 00:29:56 PST 2020

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

Looks good. Thanks for catching that.

I am particularly happy that we now have an explicit DW_FORM_ref_addr test. It's a very interesting/tricky case, but it does not happen all that often in practice.

================
Comment at: lldb/test/Shell/SymbolFile/DWARF/DW_AT_decl_file-DW_AT_specification-crosscu.s:97
+	.byte	1                               # Abbrev [1] 0xb:0x40 DW_TAG_compile_unit
+	.long	.Linfo_string_producer                  # DW_AT_producer
+	.short	12                              # DW_AT_language
----------------
These almost-aligned comments are fairly disorienting.

================
Comment at: lldb/test/Shell/SymbolFile/DWARF/DW_AT_decl_file-DW_AT_specification-crosscu.s:145-153
+	.asciz	"clang version 12.0.0" # string offset=0
+.Linfo_string_source:
+	.asciz	"source.c" # string offset=130
+.Linfo_string_directory:
+	.asciz	"/directory" # string offset=196
+.Linfo_string_main:
+	.asciz	"main"                          # string offset=232
----------------
the offset comments are misaligned  and incorrect

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91014/new/

https://reviews.llvm.org/D91014