[Lldb-commits] [PATCH] D91003: [lldb] [test] Use skipUnlessDarwin for tests specific to Darwin

[Raphael Isemann via Phabricator via lldb-commits]

teemperor added a comment.

In D91003#2381885 <https://reviews.llvm.org/D91003#2381885>, @mgorny wrote:

> In D91003#2381881 <https://reviews.llvm.org/D91003#2381881>, @labath wrote:
>
>> If we put all of the objc tests into objc-specific directories (it looks like most of them are there already, but I spotted two outliers in this patch), then we could mark those directories with the existing "objc" category, and use the existing category-based skipping mechanism. I don't remember seeing the code for setting the objc category, so I don't know how it works, but it shouldn't be hard to make it skip this category on platforms which don't (currently) support objc.
>
> Actually, I've started working on this but I don't know how to reliably detect all Darwin platforms, with all the weird simulator environments and so on, from lit.

Could you just do this via a feature check? For libc++ we try compiling a dummy file (grep for `checkLibcxxSupport`) and we could do the same with a very simple Obj-C program including `NSObject.h`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91003/new/

https://reviews.llvm.org/D91003