[Lldb-commits] [PATCH] D90987: [lldb] Avoid confusing crashes during reproducer replay when initialization failed
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Nov 9 00:14:27 PST 2020
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
I wonder if there's a way to add some consistency checks into the (active) replay machinery. Like, maybe we could, for each function that returns an SBError, record a flag saying whether that error was in a success state or not. Then if this flag differs during replay, we know that we have started to diverge and can stop replaying (or at least give a very loud warning about it).
Comment at: lldb/source/API/SystemInitializerFull.cpp:46
+ if (repro::Reproducer::Instance().IsReplaying())
+ return error;
Print the error that has happened? maybe via `report_fatal_error` ?
CHANGES SINCE LAST ACTION
More information about the lldb-commits