[Lldb-commits] [lldb] 93c9110 - [lldb] [test] Use skipUnlessDarwin for tests specific to Darwin
Michał Górny via lldb-commits
lldb-commits at lists.llvm.org
Sat Nov 7 10:27:17 PST 2020
Author: Michał Górny
Date: 2020-11-07T19:26:42+01:00
New Revision: 93c9110c980c9fc4bd72fb307c18f79afa0381e3
URL: https://github.com/llvm/llvm-project/commit/93c9110c980c9fc4bd72fb307c18f79afa0381e3
DIFF: https://github.com/llvm/llvm-project/commit/93c9110c980c9fc4bd72fb307c18f79afa0381e3.diff
LOG: [lldb] [test] Use skipUnlessDarwin for tests specific to Darwin
Use skipUnlessDarwin decorator for tests that are specific to Darwin,
instead of skipIf... for all other platforms. This should make it clear
that these tests are not supposed to work elsewhere. It will also make
these tests stop repeatedly popping up while I look for tests that could
be fixed on the platform in question.
Differential Revision: https://reviews.llvm.org/D91003
Added:
Modified:
lldb/test/API/functionalities/data-formatter/setvaluefromcstring/TestSetValueFromCString.py
lldb/test/API/lang/objc/objc-foundation-dictionary-empty/TestNSDictionary0.py
lldb/test/API/lang/objc/objc-ivar-protocols/TestIvarProtocols.py
lldb/test/API/lang/objc/objc-runtime-ivars/TestRuntimeIvars.py
lldb/test/API/lang/objc/variadic_methods/TestVariadicMethods.py
lldb/test/API/lang/objcxx/class-name-clash/TestNameClash.py
lldb/test/API/lang/objcxx/hide-runtime-values/TestObjCXXHideRuntimeValues.py
lldb/test/API/lang/objcxx/objcxx-ivar-vector/TestIvarVector.py
lldb/test/API/python_api/exprpath_synthetic/TestExprPathSynthetic.py
lldb/test/API/python_api/sbtype_typeclass/TestSBTypeTypeClass.py
Removed:
################################################################################
diff --git a/lldb/test/API/functionalities/data-formatter/setvaluefromcstring/TestSetValueFromCString.py b/lldb/test/API/functionalities/data-formatter/setvaluefromcstring/TestSetValueFromCString.py
index e08667fd24c5..f0152de1ac33 100644
--- a/lldb/test/API/functionalities/data-formatter/setvaluefromcstring/TestSetValueFromCString.py
+++ b/lldb/test/API/functionalities/data-formatter/setvaluefromcstring/TestSetValueFromCString.py
@@ -2,6 +2,4 @@
from lldbsuite.test import decorators
lldbinline.MakeInlineTest(
- __file__, globals(), [
- decorators.skipIfFreeBSD, decorators.skipIfLinux,
- decorators.skipIfNetBSD, decorators.skipIfWindows])
+ __file__, globals(), [decorators.skipUnlessDarwin])
diff --git a/lldb/test/API/lang/objc/objc-foundation-dictionary-empty/TestNSDictionary0.py b/lldb/test/API/lang/objc/objc-foundation-dictionary-empty/TestNSDictionary0.py
index 562d9ae01e2a..f0152de1ac33 100644
--- a/lldb/test/API/lang/objc/objc-foundation-dictionary-empty/TestNSDictionary0.py
+++ b/lldb/test/API/lang/objc/objc-foundation-dictionary-empty/TestNSDictionary0.py
@@ -2,6 +2,4 @@
from lldbsuite.test import decorators
lldbinline.MakeInlineTest(
- __file__, globals(), [
- decorators.skipIfFreeBSD, decorators.skipIfLinux,
- decorators.skipIfWindows, decorators.skipIfNetBSD])
+ __file__, globals(), [decorators.skipUnlessDarwin])
diff --git a/lldb/test/API/lang/objc/objc-ivar-protocols/TestIvarProtocols.py b/lldb/test/API/lang/objc/objc-ivar-protocols/TestIvarProtocols.py
index 562d9ae01e2a..f0152de1ac33 100644
--- a/lldb/test/API/lang/objc/objc-ivar-protocols/TestIvarProtocols.py
+++ b/lldb/test/API/lang/objc/objc-ivar-protocols/TestIvarProtocols.py
@@ -2,6 +2,4 @@
from lldbsuite.test import decorators
lldbinline.MakeInlineTest(
- __file__, globals(), [
- decorators.skipIfFreeBSD, decorators.skipIfLinux,
- decorators.skipIfWindows, decorators.skipIfNetBSD])
+ __file__, globals(), [decorators.skipUnlessDarwin])
diff --git a/lldb/test/API/lang/objc/objc-runtime-ivars/TestRuntimeIvars.py b/lldb/test/API/lang/objc/objc-runtime-ivars/TestRuntimeIvars.py
index f1b36943ecec..41719ec68aea 100644
--- a/lldb/test/API/lang/objc/objc-runtime-ivars/TestRuntimeIvars.py
+++ b/lldb/test/API/lang/objc/objc-runtime-ivars/TestRuntimeIvars.py
@@ -3,6 +3,5 @@
lldbinline.MakeInlineTest(
__file__, globals(), [
- decorators.skipIfFreeBSD, decorators.skipIfLinux,
- decorators.skipIfWindows, decorators.skipIfNetBSD,
+ decorators.skipUnlessDarwin,
decorators.skipIf(archs=["i386", "i686"])])
diff --git a/lldb/test/API/lang/objc/variadic_methods/TestVariadicMethods.py b/lldb/test/API/lang/objc/variadic_methods/TestVariadicMethods.py
index 562d9ae01e2a..f0152de1ac33 100644
--- a/lldb/test/API/lang/objc/variadic_methods/TestVariadicMethods.py
+++ b/lldb/test/API/lang/objc/variadic_methods/TestVariadicMethods.py
@@ -2,6 +2,4 @@
from lldbsuite.test import decorators
lldbinline.MakeInlineTest(
- __file__, globals(), [
- decorators.skipIfFreeBSD, decorators.skipIfLinux,
- decorators.skipIfWindows, decorators.skipIfNetBSD])
+ __file__, globals(), [decorators.skipUnlessDarwin])
diff --git a/lldb/test/API/lang/objcxx/class-name-clash/TestNameClash.py b/lldb/test/API/lang/objcxx/class-name-clash/TestNameClash.py
index 19832aefee98..4ba088e4b035 100644
--- a/lldb/test/API/lang/objcxx/class-name-clash/TestNameClash.py
+++ b/lldb/test/API/lang/objcxx/class-name-clash/TestNameClash.py
@@ -2,6 +2,4 @@
from lldbsuite.test import lldbinline
lldbinline.MakeInlineTest(
- __file__, globals(), [
- decorators.skipIfFreeBSD, decorators.skipIfLinux,
- decorators.skipIfWindows, decorators.skipIfNetBSD])
+ __file__, globals(), [decorators.skipUnlessDarwin])
diff --git a/lldb/test/API/lang/objcxx/hide-runtime-values/TestObjCXXHideRuntimeValues.py b/lldb/test/API/lang/objcxx/hide-runtime-values/TestObjCXXHideRuntimeValues.py
index cc6ac20b84bd..9f2b5d68d5d5 100644
--- a/lldb/test/API/lang/objcxx/hide-runtime-values/TestObjCXXHideRuntimeValues.py
+++ b/lldb/test/API/lang/objcxx/hide-runtime-values/TestObjCXXHideRuntimeValues.py
@@ -9,10 +9,7 @@ class TestObjCXXHideRuntimeSupportValues(TestBase):
mydir = TestBase.compute_mydir(__file__)
- @skipIfFreeBSD
- @skipIfLinux
- @skipIfWindows
- @skipIfNetBSD
+ @skipUnlessDarwin
def test_hide_runtime_support_values(self):
self.build()
_, process, _, _ = lldbutil.run_to_source_breakpoint(
diff --git a/lldb/test/API/lang/objcxx/objcxx-ivar-vector/TestIvarVector.py b/lldb/test/API/lang/objcxx/objcxx-ivar-vector/TestIvarVector.py
index 19832aefee98..4ba088e4b035 100644
--- a/lldb/test/API/lang/objcxx/objcxx-ivar-vector/TestIvarVector.py
+++ b/lldb/test/API/lang/objcxx/objcxx-ivar-vector/TestIvarVector.py
@@ -2,6 +2,4 @@
from lldbsuite.test import lldbinline
lldbinline.MakeInlineTest(
- __file__, globals(), [
- decorators.skipIfFreeBSD, decorators.skipIfLinux,
- decorators.skipIfWindows, decorators.skipIfNetBSD])
+ __file__, globals(), [decorators.skipUnlessDarwin])
diff --git a/lldb/test/API/python_api/exprpath_synthetic/TestExprPathSynthetic.py b/lldb/test/API/python_api/exprpath_synthetic/TestExprPathSynthetic.py
index 19832aefee98..4ba088e4b035 100644
--- a/lldb/test/API/python_api/exprpath_synthetic/TestExprPathSynthetic.py
+++ b/lldb/test/API/python_api/exprpath_synthetic/TestExprPathSynthetic.py
@@ -2,6 +2,4 @@
from lldbsuite.test import lldbinline
lldbinline.MakeInlineTest(
- __file__, globals(), [
- decorators.skipIfFreeBSD, decorators.skipIfLinux,
- decorators.skipIfWindows, decorators.skipIfNetBSD])
+ __file__, globals(), [decorators.skipUnlessDarwin])
diff --git a/lldb/test/API/python_api/sbtype_typeclass/TestSBTypeTypeClass.py b/lldb/test/API/python_api/sbtype_typeclass/TestSBTypeTypeClass.py
index a06dd7a1424a..59154e4715c9 100644
--- a/lldb/test/API/python_api/sbtype_typeclass/TestSBTypeTypeClass.py
+++ b/lldb/test/API/python_api/sbtype_typeclass/TestSBTypeTypeClass.py
@@ -3,8 +3,7 @@
lldbinline.MakeInlineTest(
__file__, globals(), [
- decorators.skipIfFreeBSD, decorators.skipIfLinux,
- decorators.skipIfWindows, decorators.skipIfNetBSD,
+ decorators.skipUnlessDarwin,
decorators.expectedFailureAll(
oslist=['macosx'], archs=['i386'],
bugnumber='rdar://28656677')])
More information about the lldb-commits
mailing list