[Lldb-commits] [PATCH] D91003: [lldb] [test] Use skipUnlessDarwin for tests specific to Darwin

Sat Nov 7 10:08:04 PST 2020

teemperor added a comment.

In D91003#2380921 <https://reviews.llvm.org/D91003#2380921>, @mgorny wrote:

> In D91003#2380907 <https://reviews.llvm.org/D91003#2380907>, @teemperor wrote:
>
>> Given that these are all Objective-C tests, this LGTM.
>>
>> (Out of scope for this patch, but it would probably be cleaner if we replace all the skipUnlessDarwin uses because of Obj-C with a dedicated decorator. In theory Obj-C is available on other systems).
>
> I was kinda wondering why it is done like this, I've presumed some ObjC-specific parts of LLDB work only on Darwin.

I assume that's indeed the case given how much LLDB assumes about the implementation details of the Obj-C runtime.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91003/new/

https://reviews.llvm.org/D91003