[Lldb-commits] [PATCH] D90872: [TargetList] Simplify dummy target creation
Raphael Isemann via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu Nov 5 14:18:21 PST 2020
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
LGTM.
================
Comment at: lldb/source/Core/Debugger.cpp:685
- m_dummy_target_sp = m_target_list.GetDummyTarget(*this);
+ {
+ ArchSpec arch(Target::GetDefaultArchitecture());
----------------
Maybe have a small comment here that summarizes the block: `// Create dummy target`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90872/new/
https://reviews.llvm.org/D90872
More information about the lldb-commits
mailing list