[Lldb-commits] [lldb] b643deb - [lldb] [test] Fix TestGdbRemoteThreadName code on FreeBSD

Michał Górny via lldb-commits lldb-commits at lists.llvm.org
Thu Nov 5 11:45:47 PST 2020


Author: Michał Górny
Date: 2020-11-05T20:45:34+01:00
New Revision: b643deb03fb935d414f74e07b702ebb4e5c33bf3

URL: https://github.com/llvm/llvm-project/commit/b643deb03fb935d414f74e07b702ebb4e5c33bf3
DIFF: https://github.com/llvm/llvm-project/commit/b643deb03fb935d414f74e07b702ebb4e5c33bf3.diff

LOG: [lldb] [test] Fix TestGdbRemoteThreadName code on FreeBSD

Fix TestGdbRemoteThreadName to call ::pthread_setname_np instead
of ::pthread_set_name_np on FreeBSD.  While technically both names
are correct, the former is preferable because of compatibility
with Linux.  Furthermore, the latter requires `#include <pthread_np.h>`
that was missing causing the test to fail to compile.

Differential Revision: https://reviews.llvm.org/D90862

Added: 
    

Modified: 
    lldb/test/API/tools/lldb-server/thread-name/main.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/tools/lldb-server/thread-name/main.cpp b/lldb/test/API/tools/lldb-server/thread-name/main.cpp
index 898e9a35e9ac..02eea12ca98a 100644
--- a/lldb/test/API/tools/lldb-server/thread-name/main.cpp
+++ b/lldb/test/API/tools/lldb-server/thread-name/main.cpp
@@ -4,9 +4,7 @@
 void set_thread_name(const char *name) {
 #if defined(__APPLE__)
   ::pthread_setname_np(name);
-#elif defined(__FreeBSD__)
-  ::pthread_set_name_np(::pthread_self(), name);
-#elif defined(__linux__)
+#elif defined(__FreeBSD__) || defined(__linux__)
   ::pthread_setname_np(::pthread_self(), name);
 #elif defined(__NetBSD__)
   ::pthread_setname_np(::pthread_self(), "%s", const_cast<char *>(name));


        


More information about the lldb-commits mailing list