[Lldb-commits] [PATCH] D90757: [lldb] Enable FreeBSDRemote plugin by default and update test status

[Michał Górny via Phabricator via lldb-commits]

mgorny marked an inline comment as done.
mgorny added inline comments.


================
Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:955
 
-    # Don't do lldb-server (llgs) tests on anything except Linux and Windows.
+    # Don't do lldb-server (llgs) tests on platforms not supporting it.
     configuration.dont_do_llgs_test = not (
----------------
emaste wrote:
> It's a shame that these variables and the comments are inverted sense / double negatives, but not an issue in this patch.
Yes, I had to look at it for a while to make sure I'm doing it right. I'll change them in a followup commit.


================
Comment at: lldb/test/API/commands/register/register/register_command/TestRegisters.py:31
     @skipIf(archs=no_match(['amd64', 'arm', 'i386', 'x86_64']))
-    @expectedFailureNetBSD
+    @expectedFailureAll(oslist=["freebsd", "netbsd"])
     def test_register_commands(self):
----------------
emaste wrote:
> there's no (existing) PR for the failure?
No. I'm planning to file bugs during the next stage, after trying to fix the trivial ones, if that's ok with you.


================
Comment at: lldb/test/API/commands/watchpoints/multiple_threads/TestWatchpointMultipleThreads.py:25
 
+    @expectedFailureAll(oslist=["freebsd"])
     def test_watchpoint_after_thread_start(self):
----------------
emaste wrote:
> was this one already failing, or is this new?
Yes, it is new. I must've attributed it to unstable tests when I reported no regressions yesterday. However, today I've confirmed it to fail reliably. Hopefully, it won't be hard to fix once I get to it.


================
Comment at: lldb/test/API/functionalities/exec/TestExec.py:23
     @skipIfAsan # rdar://problem/43756823
+    @skipIfFreeBSD  # hangs
     @skipIfWindows
----------------
emaste wrote:
> So hangs on FreeBSD but reliably fails on NetBSD?
> 
> 
Yes, or at least it reliably failed on NetBSD the last time I checked.


================
Comment at: lldb/test/API/functionalities/thread/create_after_attach/TestCreateAfterAttach.py:25
 
-    @skipIfFreeBSD  # Hangs.  May be the same as Linux issue llvm.org/pr16229 but
     # not yet investigated.  Revisit once required functionality
     # is implemented for FreeBSD.
----------------
emaste wrote:
> part of comment here disappeared
Thanks for noticing. Restored it and move nearer to the new skip.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90757/new/

https://reviews.llvm.org/D90757