[Lldb-commits] [PATCH] D90706: [crashlog] Pass the debugger around instead of relying on lldb.debugger
Jonas Devlieghere via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Nov 4 10:29:17 PST 2020
JDevlieghere marked an inline comment as done.
JDevlieghere added inline comments.
================
Comment at: lldb/examples/python/crashlog.py:853
+ # can rely on lldb.debugger being set.
+ SymbolicateCrashLogs(lldb.debugger, shlex.split(command))
except Exception as e:
----------------
vsk wrote:
> Why does crashlog.Symbolicate accept a debugger parameter?
It's the signature lldb expects for `command script add`, but good point, we shouldn't use `lldb.debugger` and just forward the one we're passed in.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90706/new/
https://reviews.llvm.org/D90706
More information about the lldb-commits
mailing list