[Lldb-commits] [PATCH] D90757: [lldb] Enable FreeBSDRemote plugin by default and update test status

[Ed Maste via Phabricator via lldb-commits]

emaste added a comment.

I added comments in the now-dereferenced bugs linking back to this review - most of them were submitted by me, and I'll double check and close them once this lands.

One minor update needed (restoring a comment that was partially deleted)



================
Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:955
 
-    # Don't do lldb-server (llgs) tests on anything except Linux and Windows.
+    # Don't do lldb-server (llgs) tests on platforms not supporting it.
     configuration.dont_do_llgs_test = not (
----------------
It's a shame that these variables and the comments are inverted sense / double negatives, but not an issue in this patch.


================
Comment at: lldb/test/API/commands/register/register/register_command/TestRegisters.py:31
     @skipIf(archs=no_match(['amd64', 'arm', 'i386', 'x86_64']))
-    @expectedFailureNetBSD
+    @expectedFailureAll(oslist=["freebsd", "netbsd"])
     def test_register_commands(self):
----------------
there's no (existing) PR for the failure?


================
Comment at: lldb/test/API/commands/watchpoints/multiple_threads/TestWatchpointMultipleThreads.py:25
 
+    @expectedFailureAll(oslist=["freebsd"])
     def test_watchpoint_after_thread_start(self):
----------------
was this one already failing, or is this new?


================
Comment at: lldb/test/API/functionalities/exec/TestExec.py:23
     @skipIfAsan # rdar://problem/43756823
+    @skipIfFreeBSD  # hangs
     @skipIfWindows
----------------
So hangs on FreeBSD but reliably fails on NetBSD?




================
Comment at: lldb/test/API/functionalities/thread/create_after_attach/TestCreateAfterAttach.py:25
 
-    @skipIfFreeBSD  # Hangs.  May be the same as Linux issue llvm.org/pr16229 but
     # not yet investigated.  Revisit once required functionality
     # is implemented for FreeBSD.
----------------
part of comment here disappeared


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90757/new/

https://reviews.llvm.org/D90757